linux-kernel - Re: [RFT][PATCH] PCI / ACPI: Do not require MSI support for PCIe native features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110314182636.GA4069@xanatos>
Date:	Mon, 14 Mar 2011 11:26:36 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	ACPI Devel Mailing List <linux-acpi@...r.kernel.org>,
	Len Brown <lenb@...nel.org>,
	Matthew Garrett <mjg59@...f.ucam.org>
Subject: Re: [RFT][PATCH] PCI / ACPI: Do not require MSI support for PCIe
 native features

Hi Rafael,

I applied this patch, on top of this patch:
PCI/ACPI: Report ASPM support to BIOS if not disabled from command line

Unfortunately, the Express Card still doesn't show up.  The trace looks
slightly different, but the irq still gets disabled.  dmesg is attached.

Sarah Sharp

On Sat, Mar 05, 2011 at 10:54:48PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> After commit 415e12b2379239973feab91850b0dce985c6058a
> (PCI/ACPI: Request _OSC control once for each root bridge (v3)) we
> require MSI to be supported so that we use _OSC to request control
> of PCIe native features (hotplug, AER, PME), but that appears to
> be overkill and causes problems to happen on some systems.  For
> this reason, request control of PCIe native features via _OSC
> even if MSI support is not enabled.
> 
> Reported-by: Sarah Sharp <sarah.a.sharp@...ux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> ---
> 
> Hi,
> 
> Sarah, please test this patch on your machine causing PCIe hotplug
> problems on top of the patch from https://patchwork.kernel.org/patch/612171/
> and on top of 2.6.38-rc6 or later.
> 
> Thanks,
> Rafael
> 
> ---
>  drivers/acpi/pci_root.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: linux-2.6/drivers/acpi/pci_root.c
> ===================================================================
> --- linux-2.6.orig/drivers/acpi/pci_root.c
> +++ linux-2.6/drivers/acpi/pci_root.c
> @@ -50,8 +50,7 @@ static int acpi_pci_root_start(struct ac
>  
>  #define ACPI_PCIE_REQ_SUPPORT (OSC_EXT_PCI_CONFIG_SUPPORT \
>  				| OSC_ACTIVE_STATE_PWR_SUPPORT \
> -				| OSC_CLOCK_PWR_CAPABILITY_SUPPORT \
> -				| OSC_MSI_SUPPORT)
> +				| OSC_CLOCK_PWR_CAPABILITY_SUPPORT)
>  
>  static const struct acpi_device_id root_device_ids[] = {
>  	{"PNP0A03", 0},
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

View attachment "dmesg.txt" of type "text/plain" (81932 bytes)