linux-kernel - Re: [PATCH v2 12/12] driver: Google Memory Console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTino-QB=2ctS4QFWQAr3gXTc5GfC5q5bQcFguVNs@mail.gmail.com>
Date:	Mon, 14 Mar 2011 13:03:30 -0700
From:	Mike Waychison <mikew@...gle.com>
To:	"H. Peter Anvin" <hpa@...nel.org>
Cc:	Greg KH <greg@...ah.com>, Matt Domsch <Matt_Domsch@...l.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Duncan Laurie <dlaurie@...gle.com>,
	Aaron Durbin <adurbin@...gle.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Tim Hockin <thockin@...gle.com>,
	San Mehat <san@...gle.com>
Subject: Re: [PATCH v2 12/12] driver: Google Memory Console

On Sun, Mar 13, 2011 at 9:54 PM, H. Peter Anvin <hpa@...nel.org> wrote:
> On 03/11/2011 05:43 PM, Mike Waychison wrote:
>> This patch introduces the 'memconsole' driver.
>>
>> Our firmware gives us access to an in-memory log of the firmware's
>> output.   This gives us visibility in a data-center of headless machines
>> as to what the firmware is doing.
>>
>> The memory console is found by the driver by finding a header block in
>> the EBDA.  The buffer is then copied out, and is exported to userland in
>> the file /sys/firmware/log.
>>
>
> OK, I really don't like this.
>
> All it has is a 32-bit nonrandom signature, no DMI keying or anything
> else to protect it.  This really isn't sufficient.

Good point.  I'll add some DMI strings checks.  It *should* be
sufficient to just ensure that "Google, Inc." is the board vendor
string (though I'll need to run some tests to verify that this covers
the boards we care about).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/