linux-kernel - Re: [RFC][PATCH v2 00/23] (alpha) __vmalloc: add gfp flags variant of pte and pmd allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1103141351210.31514@chino.kir.corp.google.com>
Date:	Mon, 14 Mar 2011 13:54:54 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Prasad Joshi <prasadjoshi124@...il.com>
cc:	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Matt Turner <mattst88@...il.com>, linux-alpha@...r.kernel.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [RFC][PATCH v2 00/23] (alpha) __vmalloc: add gfp flags variant
 of pte and pmd allocation

On Mon, 14 Mar 2011, Prasad Joshi wrote:

> __vmalloc: propagating GFP allocation flag.
> 

This isn't the correct title of the patch.  You don't need to actually 
give them titles, the subject line will be used instead.

The subject line should also indicate this as patch 01/2 and it should 
read "mm, alpha: add gfp flags variant of pte and pmd allocations".

> - adds functions to allow caller to pass the GFP flag for memory allocation
> - helps in fixing the Bug 30702 (__vmalloc(GFP_NOFS) can callback
>   file system evict_inode).
> 
> Signed-off-by: Anand Mitra <mitra@...nfotech.com>
> Signed-off-by: Prasad Joshi <prasadjoshi124@...il.com>

The first signed-off-by line usually indicates the author of the change in 
which case this would require the first line of the email to be

From: Anand Mitra <mitra@...nfotech.com>

if that's the correct attribution.

> ---
> Chnagelog:
> arch/alpha/include/asm/pgalloc.h |   18 ++++++++++++++----
> 1 files changed, 14 insertions(+), 4 deletions(-)
> ---
> diff --git a/arch/alpha/include/asm/pgalloc.h b/arch/alpha/include/asm/pgalloc.h
> index bc2a0da..d05dfc2 100644
> --- a/arch/alpha/include/asm/pgalloc.h
> +++ b/arch/alpha/include/asm/pgalloc.h
> @@ -38,10 +38,15 @@ pgd_free(struct mm_struct *mm, pgd_t *pgd)
>  }
> 
>  static inline pmd_t *
> +__pmd_alloc_one(struct mm_struct *mm, unsigned long address, gfp_t gfp_mask)
> +{
> +	return (pmd_t *)__get_free_page(gfp_mask | __GFP_ZERO);
> +}
> +
> +static inline pmd_t *
>  pmd_alloc_one(struct mm_struct *mm, unsigned long address)
>  {
> -	pmd_t *ret = (pmd_t *)__get_free_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
> -	return ret;
> +	return __pmd_alloc_one(mm, address, GFP_KERNEL | __GFP_REPEAT);
>  }
> 
>  static inline void
> @@ -51,10 +56,15 @@ pmd_free(struct mm_struct *mm, pmd_t *pmd)
>  }
> 
>  static inline pte_t *
> +__pte_alloc_one_kernel(struct mm_struct *mm, unsigned long addressi,
> gfp_t gfp_mask)

This patch is corrupt probably because of your email client (and all other 
patches in this series are corrupt, as well).  Please see 
Documentation/email-clients.txt and try sending test patches to a 
colleague and git-apply them first.

BTW, s/addressi/address/ for this function definition.

> +{
> +	return (pte_t *)__get_free_page(gfp_mask | __GFP_ZERO);
> +}
> +
> +static inline pte_t *
>  pte_alloc_one_kernel(struct mm_struct *mm, unsigned long address)
>  {
> -	pte_t *pte = (pte_t *)__get_free_page(GFP_KERNEL|__GFP_REPEAT|__GFP_ZERO);
> -	return pte;
> +	return __pte_alloc_one_kernel(mm, address, GFP_KERNEL | __GFP_REPEAT);
>  }
> 
>  static inline void
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/