linux-kernel - linux-next: build failure after merge of the bkl-config tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110315184845.1a411e67.sfr@canb.auug.org.au>
Date:	Tue, 15 Mar 2011 18:48:45 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andy Adamson <andros@...app.com>,
	Boaz Harrosh <bharrosh@...asas.com>,
	Dean Hildebrand <dhildeb@...ibm.com>,
	Fred Isaman <iisaman@...i.umich.edu>,
	Mike Sager <sager@...app.com>,
	Fred Isaman <iisaman@...app.com>,
	Mingyang Guo <guomingyang@...hpc.ac.cn>,
	Ricardo Labiaga <Ricardo.Labiaga@...app.com>,
	Tao Guo <guotao@...hpc.ac.cn>,
	Andy Adamson <andros@...app.com>,
	Benny Halevy <bhalevy@...asas.com>,
	Trond Myklebust <trond.myklebust@....uio.no>
Subject: linux-next: build failure after merge of the bkl-config tree

Hi Arnd,

After merging the bkl-config tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/nfs/read.c:21:28: error: linux/smp_lock.h: No such file or directory

Caused by commit 64419a9b2093 ("NFSv4.1: generic read") from the nfs tree
interacting with commit 4ba8216cd905 ("BKL: That's all, folks") from the
bkl-config tree.

I couldn't see that this include file was needed, so I applied the patch
below (which Trond could apply to his tree, I am pretty sure).  (I am not
sure why module.h is included either.)

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Tue, 15 Mar 2011 18:37:09 +1100
Subject: [PATCH] nfs: BKL is no longer needed, so remove the include

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 fs/nfs/read.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/read.c b/fs/nfs/read.c
index 4b764c6..7cded2b 100644
--- a/fs/nfs/read.c
+++ b/fs/nfs/read.c
@@ -18,7 +18,6 @@
 #include <linux/sunrpc/clnt.h>
 #include <linux/nfs_fs.h>
 #include <linux/nfs_page.h>
-#include <linux/smp_lock.h>
 #include <linux/module.h>
 
 #include <asm/system.h>
-- 
1.7.4.1


-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/