[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110315102720.GC24496@lst.de>
Date: Tue, 15 Mar 2011 11:27:20 +0100
From: Christoph Hellwig <hch@....de>
To: "Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc: linux-scsi <linux-scsi@...r.kernel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
James Bottomley <James.Bottomley@...senPartnership.com>,
Christoph Hellwig <hch@....de>,
Mike Christie <michaelc@...wisc.edu>,
Hannes Reinecke <hare@...e.de>,
FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
Boaz Harrosh <bharrosh@...asas.com>,
Stephen Rothwell <sfr@...b.auug.org.au>,
Douglas Gilbert <dgilbert@...erlog.com>
Subject: Re: [RFC-v2 11/12] iscsi-target: Add misc utility and debug logic
On Mon, Mar 14, 2011 at 04:57:08AM -0700, Nicholas A. Bellinger wrote:
> +++ b/drivers/target/iscsi/iscsi_debug.h
> @@ -0,0 +1,113 @@
> +#ifndef ISCSI_DEBUG_H
> +#define ISCSI_DEBUG_H
> +
> +/*
> + * Debugging Support
> + */
> +
> +#define TRACE_DEBUG 0x00000001 /* Verbose debugging */
> +#define TRACE_SCSI 0x00000002 /* Stuff related to SCSI Mid-layer */
Please use trace events for this kind of debugging.
> + spin_lock_bh(&conn->cmd_lock);
> + list_add_tail(&cmd->i_list, &conn->conn_cmd_list);
> + spin_unlock_bh(&conn->cmd_lock);
> +
> + atomic_inc(&conn->active_cmds);
Seems like this counter is always maintained together with the list,
so it should be a non-atomic type under cmd_lock.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists