linux-kernel - Re: [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from koneplus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1103151541540.19969@pobox.suse.cz>
Date:	Tue, 15 Mar 2011 15:41:59 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Stefan Achatz <erazor_de@...rs.sourceforge.net>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from
 koneplus driver

On Mon, 14 Mar 2011, Stefan Achatz wrote:

> Mode of sysfs attribute 'sensor' was wrongly set to writeonly.
> Corrected this to readwrite.
> 
> Signed-off-by: Stefan Achatz <erazor_de@...rs.sourceforge.net>
> ---
>  drivers/hid/hid-roccat-koneplus.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-roccat-koneplus.c b/drivers/hid/hid-roccat-koneplus.c
> index a8e2117..33eec74 100644
> --- a/drivers/hid/hid-roccat-koneplus.c
> +++ b/drivers/hid/hid-roccat-koneplus.c
> @@ -460,7 +460,7 @@ static struct device_attribute koneplus_attributes[] = {
>  
>  static struct bin_attribute koneplus_bin_attributes[] = {
>  	{
> -		.attr = { .name = "sensor", .mode = 0220 },
> +		.attr = { .name = "sensor", .mode = 0660 },
>  		.size = sizeof(struct koneplus_sensor),
>  		.read = koneplus_sysfs_read_sensor,
>  		.write = koneplus_sysfs_write_sensor

Applied.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/