linux-kernel - Re: [PATCH -next] soc: sgtl5000 uses regulator interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110315084117.1e3a3a61.randy.dunlap@oracle.com>
Date:	Tue, 15 Mar 2011 08:41:17 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Zeng Zhaoming <zengzm.kernel@...il.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Zeng Zhaoming <zhaoming.zeng@...escale.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH -next] soc: sgtl5000 uses regulator interfaces

On Sat, 5 Mar 2011 20:41:38 +0800 Zeng Zhaoming wrote:

> On Sat, Mar 5, 2011 at 7:29 PM, Mark Brown
> <broonie@...nsource.wolfsonmicro.com> wrote:
> > On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@...cle.com>
> >>
> >> sgtl5000 uses regulator interfaces, so make selecting it depend
> >> on REGULATOR.
> >>
> >> sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister'
> >> sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata'
> >> sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'
> >
> 
> hi， Thanks for the report.
> 
> > Since the regulator on the device is optional this isn't the best fix,
> > the code should be updated to support building without regulator.
> 
> I will fix the code. If regulator not enabled, and the optional
> regulator not provided externally,
> a warning message will print out, and internal regulator will set
> directly by write register.
> > --

ping.  This build error still happens in linux-next 2011.0315.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/