linux-kernel - Re: [PATCH] char/ipmi: fix cleanup_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110315093756.04c40840.randy.dunlap@oracle.com>
Date:	Tue, 15 Mar 2011 09:37:56 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Cc:	Corey Minyard <minyard@....org>,
	Grant Likely <grant.likely@...retlab.ca>,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Peter Huewe <peterhuewe@....de>
Subject: Re: [PATCH] char/ipmi: fix cleanup_one_si section mismatch

On Tue, 15 Feb 2011 11:52:45 +0200 Sergey Senozhatsky wrote:

> 
> commit d2478521afc20227658a10a8c5c2bf1a2aa615b3
> Author: Corey Minyard<minyard@....org>
> Date:   Thu Feb 10 16:08:38 2011 -0600
> 
>      char/ipmi: fix OOPS caused by pnp_unregister_driver on unregistered driver
> 
> 
> Introduced section mismatch by calling __exit cleanup_ipmi_si from __devinit 
> init_ipmi_si. Remove __exit annotation from cleanup_ipmi_si.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> Acked-by: Corey Minyard <cminyard@...sta.com>

Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

Thanks.

> ---
> 
>  drivers/char/ipmi/ipmi_si_intf.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 7855f9f..94cd2ce 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -3532,7 +3532,7 @@ static void cleanup_one_si(struct smi_info *to_clean)
>  	kfree(to_clean);
>  }
>  
> -static void __exit cleanup_ipmi_si(void)
> +static void cleanup_ipmi_si(void)
>  {
>  	struct smi_info *e, *tmp_e;
>  
> --


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/