linux-kernel - Re: linux-next: build warning after merge of the slab tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1103151119200.5754@router.home>
Date:	Tue, 15 Mar 2011 12:45:21 -0500 (CDT)
From:	Christoph Lameter <cl@...ux.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
cc:	Pekka Enberg <penberg@...helsinki.fi>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: linux-next: build warning after merge of the slab tree

On Mon, 14 Mar 2011, Stephen Rothwell wrote:

> mm/slub.c: In function 'slab_free':
> mm/slub.c:2124: warning: label 'redo' defined but not used
>
> Introduced by commit 8a5ec0ba42c4 ("Lockless (and preemptless) fastpaths
> for slub").
---

Subject: slub: Dont define useless label in the !CONFIG_CMPXCHG_LOCAL case

The redo label needs #ifdeffery.

Signed-off-by: Christoph Lameter <cl@...ux.com>

 mm/slub.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Index: linux-next/mm/slub.c
===================================================================
--- linux-next.orig/mm/slub.c	2011-03-15 12:41:41.000000000 -0500
+++ linux-next/mm/slub.c	2011-03-15 12:43:06.000000000 -0500
@@ -2119,9 +2119,11 @@ static __always_inline void slab_free(st

 #ifndef CONFIG_CMPXCHG_LOCAL
 	local_irq_save(flags);
-#endif

+#else
 redo:
+#endif
+
 	/*
 	 * Determine the currently cpus per cpu slab.
 	 * The cpu may change afterward. However that does not matter since
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/