linux-kernel - Re: [PATCH v3] introduce sys_syncfs to sync a single file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110315131846.4d41af3c.akpm@linux-foundation.org>
Date:	Tue, 15 Mar 2011 13:18:46 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Andreas Dilger <adilger@...ger.ca>
Cc:	Dave Chinner <david@...morbit.com>, Sage Weil <sage@...dream.net>,
	Indan Zupancic <indan@....nu>, Greg KH <greg@...ah.com>,
	Jonathan Nieder <jrnieder@...il.com>,
	Arnd Bergmann <arnd@...db.de>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>,
	"linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
	"mtk.manpages@...il.com" <mtk.manpages@...il.com>,
	"viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
	"hch@....de" <hch@....de>, "l@...per.es" <l@...per.es>
Subject: Re: [PATCH v3] introduce sys_syncfs to sync a single file system

On Tue, 15 Mar 2011 09:56:08 -0600
Andreas Dilger <adilger@...ger.ca> wrote:

> Should there be a "wait" argument or flag that allows an app to start the syncfs(), do something, and then call again to wait for completion?

I don't think so.  If userspace wants to do that then fork().

> > Perhaps we should consider propagating errors out to the user
> > application rather than discarding them in kernel and pretending we
> > can't ever have a write error?

That would be nice, but is probably a pretty complex thing to
implement.  The manpage should include words indicating that syncfs()
can return an errno.  That way, userspace will hopefully have the
appropriate checks, whcih will become more useful if/when the kernel
implementation gets fixed up.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/