linux-kernel - Re: [RFC-v2 06/12] iscsi-target: Add iSCSI Login Negotiation and Parameter logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Mar 2011 15:55:19 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Christoph Hellwig <hch@....de>
Cc:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Mike Christie <michaelc@...wisc.edu>,
	Hannes Reinecke <hare@...e.de>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Boaz Harrosh <bharrosh@...asas.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Douglas Gilbert <dgilbert@...erlog.com>
Subject: Re: [RFC-v2 06/12] iscsi-target: Add iSCSI Login Negotiation and
	Parameter logic

On Tue, 2011-03-15 at 11:21 +0100, Christoph Hellwig wrote:
> The thread pool in iscsi_thread_queue.c looks like it really should
> go away in favour of the new concurrency managed workqueues.

Yes, this code has been around for some time..

> Did you look into the current kernel kernel/workqueue.c code?
> 

I was thinking more about this for target core v4.1 / .40 stuff, but
have not looked at this for iSCSI target not just yet..

I think this would be a good fit for immediate and response queues in
iscsi_target_tx_thread(), and I think we could convert with fairly
minimal breakage to the existing code if I understand Tejun's new model
correct.  I need to read-up a bit more before jumping on this
conversion, but if you want to do an initial conversion I would be happy
to merge it and help with the polish while I address your other
comments.

--nab

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/