linux-kernel - Re: [PATCH v3 5/5] driver: Google Memory Console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110315071334.GA29969@elte.hu>
Date:	Tue, 15 Mar 2011 08:13:34 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mike Waychison <mikew@...gle.com>
Cc:	Greg KH <greg@...ah.com>, Matt Domsch <Matt_Domsch@...l.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Duncan Laurie <dlaurie@...gle.com>,
	Aaron Durbin <adurbin@...gle.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Tim Hockin <thockin@...gle.com>,
	San Mehat <san@...gle.com>
Subject: Re: [PATCH v3 5/5] driver: Google Memory Console


* Mike Waychison <mikew@...gle.com> wrote:

> +static struct dmi_system_id memconsole_dmi_table[] __initdata = {
> +	{
> +		.ident = "Google Board",
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "Google, Inc."),
> +		},
> +	},
> +	{}
> +};
> +MODULE_DEVICE_TABLE(dmi, memconsole_dmi_table);
> +
> +static int __init memconsole_init(void)
> +{
> +	int ret;
> +
> +	if (!dmi_check_system(memconsole_dmi_table))
> +		return -ENODEV;
> +
> +	if (!found_memconsole())
> +		return -ENODEV;

Ok, that's a much safer method of discovery.

Acked-by: Ingo Molnar <mingo@...e.hu>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/