linux-kernel - Re: [PATCH 01/22] sched: Provide scheduler_ipi() callback in response to smp_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300264215.2250.74.camel@laptop>
Date:	Wed, 16 Mar 2011 09:30:15 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	frank.rowand@...sony.com
Cc:	Chris Mason <chris.mason@...cle.com>,
	"Rowand, Frank" <Frank_Rowand@...yusa.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Mike Galbraith <efault@....de>,
	Oleg Nesterov <oleg@...hat.com>, Paul Turner <pjt@...gle.com>,
	Jens Axboe <axboe@...nel.dk>,
	Yong Zhang <yong.zhang0@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Russell King <rmk+kernel@....linux.org.uk>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Chris Metcalf <cmetcalf@...era.com>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Ralf Baechle <ralf@...ux-mips.org>, davem <davem@...emloft.net>
Subject: Re: [PATCH 01/22] sched: Provide scheduler_ipi() callback in
 response to smp_send_reschedule()

On Thu, 2011-03-10 at 17:36 -0800, Frank Rowand wrote:
> 
> > Index: linux-2.6/arch/sparc/kernel/smp_32.c
> > ===================================================================
> > --- linux-2.6.orig/arch/sparc/kernel/smp_32.c
> > +++ linux-2.6/arch/sparc/kernel/smp_32.c
> > @@ -125,7 +125,7 @@ struct linux_prom_registers smp_penguin_
> > 
> >  void smp_send_reschedule(int cpu)
> >  {
> > -       /* See sparc64 */
> > +       scheduler_ipi();
> >  }
> 
> If I understand correctly, this is calling scheduler_ipi() on the
> cpu that should be sending an IPI, not on the cpu receiving the IPI.
> If so, smp_send_reschedule() needs to send an IPI, and the scheduler_ipi()
> put in the place where the IPI is processed. 

Yes, D'0h.. Dave how does sparc32 work here? There appears to be an ipi
missing.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/