linux-kernel - Re: musb as module broken in 2.6.38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D808729.9060608@ahsoftware.de>
Date:	Wed, 16 Mar 2011 10:47:21 +0100
From:	Alexander Holler <holler@...oftware.de>
To:	balbi@...com
CC:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: musb as module broken in 2.6.38

Am 16.03.2011 10:03, schrieb Felipe Balbi:
> Hi,
>
> On Wed, Mar 16, 2011 at 02:55:53AM +0100, Alexander Holler wrote:
>> in commit dc09886bfa781e2b442301116c18199519e36f0f the name of the
>> platform-driver was splitted and musb-omap2430 is used for several
>> boards (arch/arm/mach-omap2/usb-musb.c).
>>
>> But musb_hdrc still uses musb-hdrc as name when
>> platform_driver_probe() is called. The result is that loading the
>> driver (when build as a module) doesn't work anymore (it doesn't find
>> the platform-device).
>>
>> Do I miss something or was something forgotten when the glue-layers
>> for musb got introduced?
>>
>> (The driver still works when linked into the kernel, but is
>> disfunctional when build as a module.)
>
> Send me the output you get on console and a snippet of the .config with
> the MUSB section.

I don't see the need for it, but here it is:

------------
beagle linux # grep -i MUSB .config
CONFIG_USB_MUSB_HDRC=m
# CONFIG_USB_MUSB_TUSB6010 is not set
CONFIG_USB_MUSB_OMAP2PLUS=y
# CONFIG_USB_MUSB_AM35X is not set
# CONFIG_USB_MUSB_HOST is not set
# CONFIG_USB_MUSB_PERIPHERAL is not set
CONFIG_USB_MUSB_OTG=y
CONFIG_USB_GADGET_MUSB_HDRC=y
CONFIG_USB_MUSB_HDRC_HCD=y
# CONFIG_MUSB_PIO_ONLY is not set
CONFIG_USB_MUSB_DEBUG=y
beagle linux # modprobe musb_hdrc
FATAL: Error inserting musb_hdrc 
(/lib/modules/2.6.38-beagleboard-00002-g0017ea0-dirty/kernel/drivers/usb/musb/musb_hdrc.ko): 
No such device
beagle linux # tail -n 1 /var/log/messages
Mar 16 10:37:51 beagle kernel: [  177.302825] musb-hdrc: version 6.0, 
musb-dma, otg (peripheral+host), debug=5
beagle linux # ls /sys/devices/platform/ | grep musb
musb-omap2430
------------

The problem in detail:

Through modprobe musb_core.c:musb_init() is called, and this calls 
platform_driver_probe() with a pointer to a struct of platform_device 
where the name is musb-hdrc. 
drivers/base/platform.c:platform_driver_probe() fails with -ENODEV 
because it doesn't find a platform device with the name musb-hdrc 
(list_empty()) which is understandable because the platform-device has 
the name musb-omap2430.

Regards,

Alexander Holler
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/