linux-kernel - Re: musb as module broken in 2.6.38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AF1846C5-739D-4598-83C0-34C3CBD5B9BB@ti.com>
Date:	Wed, 16 Mar 2011 12:38:08 +0200
From:	Felipe Balbi <balbi@...com>
To:	Alexander Holler <holler@...oftware.de>
Cc:	Felipe Balbi <balbi@...com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: musb as module broken in 2.6.38

hi,

On Mar 16, 2011, at 12:30 PM, Alexander Holler wrote:
> Am 16.03.2011 11:24, schrieb Felipe Balbi:
>> Hi,
>> 
>> On Mar 16, 2011, at 12:17 PM, Alexander Holler wrote:
>>>> static int __init omap2430_probe(struct platform_device *pdev)
>>> 
>>> Neither omap2430_init() nor omap2430_probe() will be called here.
>> 
>> and why is that ? It's even in sysfs already:
>> 
>>>>> beagle linux # ls /sys/devices/platform/ | grep musb
>>>>> musb-omap2430
> 
> Don't know, I haven't written or changed the driver. ;)

hehe, Just thought that you had something in mind already.

probe() functions are called when, in case of platform_devices,
the name matches with driver name. musb-omap2430 platform_device
is allocated in arch/arm/mach-omap2/usb-musb.c, then musb-2430
driver lives in drivers/usb/musb/omap2430.c. musb-2430 allocates a
platform_device for musb-hdrc core driver.

We did that because the same core is used in many different platforms
(OMAP, discrete chips, ST-Ericsson, DaVinci, PCI cards, etc) so we
needed to "abstract" platform-specific details such as clock handling
and power management.

There's still work to be done, for sure, e.g. the DMA part is still quite
screwed up, but the drivers are correctly named which means they
should be matching and probing. Now, musb-hdrc isn't probing, as
you say, and I'd like to know why. I'll try to spend some time in
it when I get back to the office.

-- 
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/