linux-kernel - Re: [PATCH] i2c: octeon: Make the timeout independent of CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110316143256.1353b0a9@endymion.delvare>
Date:	Wed, 16 Mar 2011 14:32:56 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	ben-linux@...ff.org
Cc:	Bernhard Walle <walle@...science.de>, ddaney@...iumnetworks.com,
	ralf@...ux-mips.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: octeon: Make the timeout independent of CONFIG_HZ

On Mon, 24 Jan 2011 15:00:05 +0100, Jean Delvare wrote:
> On Mon, 24 Jan 2011 13:40:26 +0100, Bernhard Walle wrote:
> > Since the timeout in the struct i2c_adapter use jiffies as unit and a
> > timeout should be independent of CONFIG_HZ, use a value of HZ/50 which
> > is equal to the current value 2 for CONFIG_HZ=100.
> > 
> > Signed-off-by: Bernhard Walle <walle@...science.de>
> 
> Acked-by: Jean Delvare <khali@...ux-fr.org>
> 
> Ben, please apply.

Ben, I can't see this fix in your tree, it seems it got lost?

> > ---
> >  drivers/i2c/busses/i2c-octeon.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c
> > index 4cffda5..d07e5c7 100644
> > --- a/drivers/i2c/busses/i2c-octeon.c
> > +++ b/drivers/i2c/busses/i2c-octeon.c
> > @@ -469,7 +469,7 @@ static struct i2c_adapter octeon_i2c_ops = {
> >  	.owner = THIS_MODULE,
> >  	.name = "OCTEON adapter",
> >  	.algo = &octeon_i2c_algo,
> > -	.timeout = 2,
> > +	.timeout = HZ/50,
> >  };
> >  
> >  /**
> 
> 


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/