linux-kernel - Question about driver ioctl, big kernel lock, mutexes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110316155033.GQ12760@beardog.cce.hp.com>
Date:	Wed, 16 Mar 2011 10:50:33 -0500
From:	scameron@...rdog.cce.hp.com
To:	linux-kernel@...r.kernel.org
Cc:	arnd@...db.de, axboe@...nel.dk, scameron@...rdog.cce.hp.com,
	dab@...com, mike.miller@...com
Subject: Question about driver ioctl, big kernel lock, mutexes

I just noticed the existence of this change (I guess
I'm a little slow):

	commit 2a48fc0ab24241755dc93bfd4f01d68efab47f5a
	Author: Arnd Bergmann <arnd@...db.de>
	Date:   Wed Jun 2 14:28:52 2010 +0200

	    block: autoconvert trivial BKL users to private mutex

	    The block device drivers have all gained new lock_kernel
	    calls from a recent pushdown, and some of the drivers
	    were already using the BKL before.

	    This turns the BKL into a set of per-driver mutexes.
	    Still need to check whether this is safe to do.

This changes the behavior of, for example, the CCISS_PASSTHRU and 
other ioctls.  Previously, these were "protected" by the Big
Kernel Lock.  Now, from what I understand and what I've observed,
the Big Kernel Lock is kind of strange, in that it auto-releases 
whenever you sleep.  This means that the ioctl path in cciss used
to allow concurrency (which is fine, they should all be thread
safe.  I'm kind of wondering why the BKL was there in the first
place.  I guess I assumed it was necessary for reasons having to
do with the upper layers.)  

Now, if I understand things correctly, with this new driver specific mutex
surrounding the ioctl path, only one thread is permitted in the ioctl path at a
time, and whether it sleeps or not, the mutex is not released until it's done.

That's a pretty big change in behavior.  Some commands sent through
the passthrough ioctls may take awhile, and they're going to block
any other ioctls from getting started while they're going.  Previously,
it was possible to saturate the controller using multiple threads or
processes hammering on the ioctl path.  This would appear to no longer
be the case.

That being said, there was previously no real limit (other than
pci_alloc_consistent eventually failing) on how many commands
could be shoved through the cciss ioctl path at once, which was probably
a bug.  It has occurred to me to put a limit on this, and return
-EBUSY when the limit is hit, though I don't know if programs using
the ioctl are prepared to receive EBUSY... but maybe that's not my
problem.

Thoughts?

I'm thinking that if there's no reason the ioctl path can't allow
concurrency, then it should allow concurrency.

-- steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/