linux-kernel - Re: [git pull] several fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1PzvHb-0006x5-IF@pomaz-ex.szeredi.hu>
Date:	Wed, 16 Mar 2011 19:17:19 +0100
From:	Miklos Szeredi <miklos@...redi.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	miklos@...redi.hu, viro@...iv.linux.org.uk,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [git pull] several fixes

On Wed, 16 Mar 2011, Linus Torvalds wrote:
> On Wed, Mar 16, 2011 at 10:17 AM, Miklos Szeredi <miklos@...redi.hu> wrote:
> >
> > __fput doesn't need a cdev_put() for O_PATH handles.
> 
> "doesn't need" or "must not have"?

It must not have one, otherwise refcounting will go astray.

That cdev_put() should really be moved into f_op->release(), but that
would be quite a bit of work.

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/