linux-kernel - Re: [PATCH] ACPI/Intel: Rework Opregion support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinexavArS+V2APjxrqMeLSzgs8QiyGAEhtWR0mh@mail.gmail.com>
Date:	Wed, 16 Mar 2011 13:46:27 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Chris Wilson <chris@...is-wilson.co.uk>
Cc:	Indan Zupancic <indan@....nu>, intel-gfx@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Matthew Garrett <mjg@...hat.com>, Len Brown <lenb@...nel.org>,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH] ACPI/Intel: Rework Opregion support

>
> Read the changelog and thread on the patch that disabled this logic, the
> failure (or at least inconsistent behaviour with the expectations of the
> HP BIOS authors) appears to be in how we initialise ACPI on the HP
> machines that causes the initial value of lid state to be incorrect. Since
> one of the laptops that Dave tests drm-next on is a HP, he was bitten by
> the bug and temporarily (we hope) disabled the logic. Or else once again,
> we will continue to light up the panel on a closed laptop.

Yeah I've no idea if the ACPI implementation is wrong or not :-(

I suspects its the BIOS actually, the BIOS wants _INI called before _REG.
The ACPI video device isn't in the EC address space, so it ends up in the
default region address space. So we'd really need to know how Windows
sets up the _REG calls for the non-EC spaces and where its calls the _INI
methods wrt to that.

The thing is I think the actual ACPI lid device is fine, its just opregion isn't
updated until we get an event later.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/