linux-kernel - Re: [PATCH 5/8] mm/slub: Factor out some common code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2011 10:01:44 +0200
From:	Pekka Enberg <penberg@...nel.org>
To:	George Spelvin <linux@...izon.com>
Cc:	herbert@...dor.hengli.com.au, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, mpm@...enic.com, penberg@...helsinki.fi,
	rientjes@...gle.com, Christoph Lameter <cl@...ux-foundation.org>
Subject: Re: [PATCH 5/8] mm/slub: Factor out some common code.

On Thu, Mar 17, 2011 at 9:07 AM, George Spelvin <linux@...izon.com> wrote:
>> I certainly don't but I'd still like to ask you to change it to
>> 'unsigned long'. That's a Linux kernel idiom and we're not going to
>> change the whole kernel.
>
> Damn, and I just prepared the following patch.  Should I, instead, do
>
> --- a/include/linux/slab_def.h
> +++ b/include/linux/slab_def.h
> @@ -62,5 +62,5 @@ struct kmem_cache {
>  /* 3) touched by every alloc & free from the backend */
>
> -       unsigned int flags;             /* constant flags */
> +       unsigned long flags;            /* constant flags */
>        unsigned int num;               /* # of objs per slab */
>
> ... because the original slab code uses an unsigned int.

Looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/