linux-kernel - Re: [PATCHv3 3/3] ARM: mx51: Add support for low power suspend on MX51

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sjumrvzk.fsf@lebrac.rtp-net.org>
Date:	Thu, 17 Mar 2011 09:29:03 +0100
From:	Arnaud Patard (Rtp) <arnaud.patard@...-net.org>
To:	Sascha Hauer <s.hauer@...gutronix.de>
Cc:	Dinh.Nguyen@...escale.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
	u.kleine-koenig@...gutronix.de, ra5478@...escale.com,
	xiao-lizhang@...escale.com, festevam@...il.com
Subject: Re: [PATCHv3 3/3] ARM: mx51: Add support for low power suspend on MX51

Sascha Hauer <s.hauer@...gutronix.de> writes:

Hi,

> On Wed, Mar 16, 2011 at 03:03:07PM -0500, Dinh.Nguyen@...escale.com wrote:
>> +
>> +struct clk *gpc_dvfs_clk;
>> +
>> +static int mx5_suspend_enter(suspend_state_t state)
>> +{
>> +	if (gpc_dvfs_clk == NULL)
>> +		gpc_dvfs_clk = clk_get(NULL, "gpc_dvfs_clk");
>
> clk_get can fail and NULL can be a valid clock.

So, I guess one may want to fail here if one can't get the clock. The
suspend will fail in hard to debug way if this clock is not enabled
at this point.

Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/