linux-kernel - Re: [PATCH] Staging: xgifb: fixed spaces coding style issue in vb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.1103171253040.2634@esdhcp041196.research.nokia.com>
Date:	Thu, 17 Mar 2011 12:59:24 +0200 (EET)
From:	Aaro Koskinen <aaro.koskinen@...ia.com>
To:	Darek Iwanski <darekiwanski13@...il.com>
cc:	gregkh@...e.de, apatard@...driva.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: xgifb: fixed spaces coding style issue in
 vb_ext.h

Hi,

On Thu, 17 Mar 2011, Darek Iwanski wrote:
> This is a patch to the vb_ext.h file that fixes up spaces warning
> found by the checkpatch.pl tool. It still has a typedef warning that I
> do not understand how to fix.

The patch is against the wrong tree, it won't apply anymore.

Anyway, all that x86 register stuff should be deleted. There should be
nothing x86 specific in this driver.

> Signed-off-by: Darek Iwanski <darekiwanski13$Gmail.com>
> ---
> drivers/staging/xgifb/vb_ext.h |   37 ++++++++++++++++++++-----------------
> 1 files changed, 20 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/xgifb/vb_ext.h b/drivers/staging/xgifb/vb_ext.h
> index 5cc4d12..a3ec4ee 100644
> --- a/drivers/staging/xgifb/vb_ext.h
> +++ b/drivers/staging/xgifb/vb_ext.h
> @@ -1,34 +1,37 @@
> -#ifndef  _VBEXT_
> -#define  _VBEXT_
> +#ifndef _VBEXT_
> +#define _VBEXT_
>
> struct DWORDREGS {
> -    unsigned long    Eax, Ebx, Ecx, Edx, Esi, Edi, Ebp;
> +	unsigned long Eax, Ebx, Ecx, Edx, Esi, Edi, Ebp;
> };
>
> struct WORDREGS {
> -    unsigned short ax, hi_ax, bx, hi_bx, cx, hi_cx, dx, hi_dx, si,
> -	    hi_si, di, hi_di, bp, hi_bp;
> +	unsigned short ax, hi_ax, bx, hi_bx, cx, hi_cx, dx, hi_dx, si,
> +		hi_si, di, hi_di, bp, hi_bp;
> };
>
> struct BYTEREGS {
> -     unsigned char al, ah, hi_al, hi_ah, bl, bh, hi_bl, hi_bh, cl, ch,
> -	     hi_cl, hi_ch, dl, dh, hi_dl, hi_dh;
> +	unsigned char al, ah, hi_al, hi_ah, bl, bh, hi_bl, hi_bh, cl, ch,
> +		hi_cl, hi_ch, dl, dh, hi_dl, hi_dh;
> };
>
> -typedef union   _X86_REGS    {
> -    struct  DWORDREGS e;
> -    struct  WORDREGS x;
> -    struct  BYTEREGS h;
> +typedef union _X86_REGS {
> +	struct DWORDREGS e;
> +	struct WORDREGS x;
> +	struct BYTEREGS h;
> } X86_REGS, *PX86_REGS;
>
> -extern   void     XGI_XG21Fun14(struct xgi_hw_device_info *pXGIHWDE, PX86_REGS pBiosArguments);
> +extern void XGI_XG21Fun14(struct xgi_hw_device_info *pXGIHWDE,
> +	PX86_REGS pBiosArguments);
> extern void XGISetDPMS(struct xgi_hw_device_info *pXGIHWDE,
> -		       unsigned long VESA_POWER_STATE);
> -extern   void     XGI_GetSenseStatus(struct xgi_hw_device_info *HwDeviceExtension, struct vb_device_info *pVBInfo);
> -extern   void     XGINew_SetModeScratch(struct xgi_hw_device_info *HwDeviceExtension, struct vb_device_info *pVBInfo) ;
> +	unsigned long VESA_POWER_STATE);
> +extern void XGI_GetSenseStatus(struct xgi_hw_device_info *HwDeviceExtension,
> +	struct vb_device_info *pVBInfo);
> +extern void XGINew_SetModeScratch(struct xgi_hw_device_info *HwDeviceExtension,
> +	struct vb_device_info *pVBInfo) ;
> extern void ReadVBIOSTablData(unsigned char ChipType,
> -			      struct vb_device_info *pVBInfo);
> +	struct vb_device_info *pVBInfo);
> extern unsigned short XGINew_SenseLCD(struct xgi_hw_device_info *,
> -				      struct vb_device_info *pVBInfo);
> +	struct vb_device_info *pVBInfo);
>
> #endif
> -- 
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/