linux-kernel - Re: linux-next: build failure after merge of the final tree (jdelvare-hwmon tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin46NLhP+0mmYELkD8zeC5o32H=-jXkySZ4R_dj@mail.gmail.com>
Date:	Thu, 17 Mar 2011 13:18:00 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Jean Delvare <khali@...ux-fr.org>,
	Hans de Goede <hdegoede@...hat.com>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree
 (jdelvare-hwmon tree related)

On Tue, Mar 15, 2011 at 11:22, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> On Tue, 15 Mar 2011 10:32:28 +0100 Jean Delvare <khali@...ux-fr.org> wrote:
>> Stephen, sorry for the inconvenience, both Hans and myself build-tested
>> the new code on an architecture where <linux/delay.h> gets included
>> implicitly, so we didn't notice it was missing.
>
> It happens.  It seems that delay.h is almost always the one that is
> forgotten.  X86 builds include it implicitly but powerpc doesn't.
>
> I wonder if we could concoct a nice checkpatch test for it.

Or remove the implicit includes on x86...

$ git grep delay\\.h arch/x86/include/
arch/x86/include/asm/apic.h:#include <linux/delay.h>
arch/x86/include/asm/dma.h:#include <linux/delay.h>
arch/x86/include/asm/i8259.h:#include <linux/delay.h>
$

At first sight, apic.h and dmah.h don't seem to need it.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/