linux-kernel - Re: [PATCH 1/4] scatterlist: new helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1300367871.7887.4.camel@maxim-laptop>
Date:	Thu, 17 Mar 2011 15:17:51 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Alex Dubov <oakad@...oo.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	James.Bottomley@...senPartnership.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] scatterlist: new helper functions

On Wed, 2011-03-16 at 23:41 -0700, Alex Dubov wrote:
> > 
> > Do you believe that any other driver is likely to ue the
> > sg
> > infrastructure which this patch adds?  Should those
> > additions be 
> > internal to the memstick code, at least for now?
> > 
> 
> Considering the comments from Fujita and James, I suppose it will be best
> for now to fold the new sg functions into the memstick patch and
> investigate how the block layer functionality can be used to a greater
> utility at some later time.

I am thinking the same thing.
If the unusual sg code is a problem, I'll think of something later to
improve it, heck I can even completely rip it off and just use kernel
pointers, relying on block core to bounce for high-mem situations.
Since its a driver for a legacy hardware, mostly provided for
completeness, the performance difference shouldn't be much.


I think its ok to merge the code with folded sg code _for_ now, and then
I will send patches to address this point you didn't like.


OK?

Best regards,
	Maxim Levitsky 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/