| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <AANLkTimvx4xkk=HyO_nv+zOiWrZhtgWvAzzjuxYin8Uy@mail.gmail.com> Date: Thu, 17 Mar 2011 23:07:02 +0800 From: Eric Miao <eric.y.miao@...il.com> To: Axel Lin <axel.lin@...il.com> Cc: linux-kernel@...r.kernel.org, Jaya Kumar <jayakumar.lkml@...il.com>, Russell King <linux@....linux.org.uk>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH 1/2] [ARM] am200epd: fix resource leak in am200_init_gpio_regs error path Applied. On Mon, Mar 7, 2011 at 1:55 PM, Axel Lin <axel.lin@...il.com> wrote: > If gpio_request fails when i > 0, gpios[0] is not freed in current > implementation. > > Signed-off-by: Axel Lin <axel.lin@...il.com> > --- > arch/arm/mach-pxa/am200epd.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/mach-pxa/am200epd.c b/arch/arm/mach-pxa/am200epd.c > index 3499fad..811d797 100644 > --- a/arch/arm/mach-pxa/am200epd.c > +++ b/arch/arm/mach-pxa/am200epd.c > @@ -128,8 +128,8 @@ static int am200_init_gpio_regs(struct metronomefb_par *par) > return 0; > > err_req_gpio: > - while (i > 0) > - gpio_free(gpios[i--]); > + while (--i >= 0) > + gpio_free(gpios[i]); > > return err; > } > -- > 1.7.2 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists