linux-kernel - Re: um: WARNING: at kernel/futex.c:786 __unqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2011 14:32:50 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	richard -rw- weinberger <richard.weinberger@...il.com>,
	laijs@...fujitsu.com, LKML <linux-kernel@...r.kernel.org>,
	user-mode-linux-devel@...ts.sourceforge.net, dvhart@...ux.intel.com
Subject: Re: um: WARNING: at kernel/futex.c:786 __unqueue_futex

On Thu, 2011-03-17 at 14:22 -0400, Steven Rostedt wrote:
> On Thu, 2011-03-17 at 18:43 +0100, Geert Uytterhoeven wrote:
> 
> > I don't know. It's not clear to me if "WARN_ON_SMP(x)" should always return "x",
> > or only on SMP?
> > 
> > E.g.
> > 
> >     if (WARN_ON_SMP(x)) {
> >        // Should we get here if "x" is true?
> >        // Or only if CONFIG_SMP and "x" are both true?
> >     }
> > 
> 
> The "Or only if CONFIG_SMP and "x" are both true.
> 
> I'll update the change to add a comment about that.
> 

We are the first user of this false return, as do { } while (0) doesn't
return anything. I'll add a comment to explain the issue, but it makes
sense to have it returns false on UNIPROCESSOR.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/