linux-kernel - Re: [patch] genirq: incorrect unlock in __setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110317200820.GF14675@home.goodmis.org>
Date:	Thu, 17 Mar 2011 16:08:20 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Dan Carpenter <error27@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] genirq: incorrect unlock in __setup_irq()

On Thu, Mar 17, 2011 at 02:43:07PM +0300, Dan Carpenter wrote:
> goto out_thread is called before we take the lock.  It causes a gcc
> warning: "kernel/irq/manage.c:858: warning: ???flags??? may be used
> uninitialized in this function"
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index acd599a..cdcdf13 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -1065,9 +1065,9 @@ mismatch:
>  
>  out_mask:
>  	free_cpumask_var(mask);
> +	raw_spin_unlock_irqrestore(&desc->lock, flags);
>  
>  out_thread:
> -	raw_spin_unlock_irqrestore(&desc->lock, flags);

That's more than a warning fix, this is a real bug.

Acked-by: Steven Rostedt <rostedt@...dims.org>

-- Steve

>  	if (new->thread) {
>  		struct task_struct *t = new->thread;
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/