linux-kernel - Re: make checkpatch warn about memset with swapped arguments.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Mar 2011 17:32:52 -0400
From:	Dave Jones <davej@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: make checkpatch warn about memset with swapped arguments.

On Thu, Mar 17, 2011 at 02:11:08PM -0700, Andrew Morton wrote:
 
 > Dave's patch is tested (I assume), so it wins ;)

indeed, it's the one I've been using for.. ages.

 > Maybe it's just me, but I think it would be better to use bzero() for
 > this operation - it's more readable and it can't be screwed up.  Then
 > checkpatch checks for memset(xxx, 0, xxx) and for memset(xxx, xxx, 0)
 > and says "hey, use bzero".  

god yes.  I don't know why it fell out of favor in userspace[*], but we
don't have to follow suit in the kernel.  I thought we actually had
a generic bzero, but it seems not from a quick grep.  I'll hack something up.

it only needs to be a #define bzero(x,y)	memset (x, 0, y);

where should it live, linux/kernel.h ?

	Dave


[*]  man bzero shows.. "This function is deprecated", which is possibly one
     of the dumbest moves ever, given how commonplace this bug is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/