linux-kernel - Re: Some fixes for pstore (Was Re: [git pull] mnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110317224252.GC22723@ZenIV.linux.org.uk>
Date:	Thu, 17 Mar 2011 22:42:52 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Tony Luck <tony.luck@...el.com>
Cc:	Xiaotian Feng <xtfeng@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: Some fixes for pstore (Was Re: [git pull] mnt_devname queue)

On Thu, Mar 17, 2011 at 02:35:42PM -0700, Tony Luck wrote:
>  	mutex_unlock(&root->d_inode->i_mutex);
>  
> -	if (!pstore_writefile(inode, dentry, data, size))
> -		goto fail_write;
> +	memcpy(private->data, data, size);
> +	inode->i_size = private->size = size;
>  
>  	inode->i_private = private;

Better move that before d_add()

>  	if (IS_ERR(root))
> -		return -ENOMEM;
> -
> -	mnt->mnt_root = root;
> -	mnt->mnt_sb = root->d_sb;
> -	pstore_mnt = mnt;
> +		return root;
>  
> -	return 0;
> +	return root;

*blink*
	if (IS_ERR(root))
		return root;
	return root;

... or am I misreading the patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/