linux-kernel - Re: Some fixes for pstore (Was Re: [git pull] mnt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110317225603.GD22723@ZenIV.linux.org.uk>
Date:	Thu, 17 Mar 2011 22:56:03 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Tony Luck <tony.luck@...il.com>
Cc:	Xiaotian Feng <xtfeng@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: Some fixes for pstore (Was Re: [git pull] mnt_devname queue)

On Thu, Mar 17, 2011 at 03:48:13PM -0700, Tony Luck wrote:
> On Thu, Mar 17, 2011 at 3:42 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> >> + ? ? memcpy(private->data, data, size);
> >> + ? ? inode->i_size = private->size = size;
> >>
> >> ? ? ? inode->i_private = private;
> >
> > Better move that before d_add()
> 
> Will do.
> 
> > *blink*
> > ? ? ? ?if (IS_ERR(root))
> > ? ? ? ? ? ? ? ?return root;
> > ? ? ? ?return root;
> >
> > ... or am I misreading the patch?
> 
> Your patch reading skills are fine ... the code deserves more than a *blink*.
> Will fix.

Send the updated patch my way, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/