linux-kernel - Re: [PATCH 27/36] perf,rcu: convert call_rcu(swevent_hlist_release_rcu) to kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1300440935.21794.30.camel@twins>
Date:	Fri, 18 Mar 2011 10:35:35 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 27/36] perf,rcu: convert
 call_rcu(swevent_hlist_release_rcu) to kfree_rcu()

On Fri, 2011-03-18 at 12:08 +0800, Lai Jiangshan wrote:
> 
> The rcu callback swevent_hlist_release_rcu() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(swevent_hlist_release_rcu).
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>

Acked-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>

> ---
>  kernel/perf_event.c |   10 +---------
>  1 files changed, 1 insertions(+), 9 deletions(-)
> 
> diff --git a/kernel/perf_event.c b/kernel/perf_event.c
> index b0581bd..43b0410 100644
> --- a/kernel/perf_event.c
> +++ b/kernel/perf_event.c
> @@ -5300,14 +5300,6 @@ swevent_hlist_deref(struct swevent_htable *swhash)
>  					 lockdep_is_held(&swhash->hlist_mutex));
>  }
>  
> -static void swevent_hlist_release_rcu(struct rcu_head *rcu_head)
> -{
> -	struct swevent_hlist *hlist;
> -
> -	hlist = container_of(rcu_head, struct swevent_hlist, rcu_head);
> -	kfree(hlist);
> -}
> -
>  static void swevent_hlist_release(struct swevent_htable *swhash)
>  {
>  	struct swevent_hlist *hlist = swevent_hlist_deref(swhash);
> @@ -5316,7 +5308,7 @@ static void swevent_hlist_release(struct swevent_htable *swhash)
>  		return;
>  
>  	rcu_assign_pointer(swhash->swevent_hlist, NULL);
> -	call_rcu(&hlist->rcu_head, swevent_hlist_release_rcu);
> +	kfree_rcu(hlist, rcu_head);
>  }
>  
>  static void swevent_hlist_put_cpu(struct perf_event *event, int cpu)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/