linux-kernel - Re: [PATCH] NFC: Driver for Inside Secure MicroRead NFC chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110318114931.GA2155@pengutronix.de>
Date:	Fri, 18 Mar 2011 12:49:32 +0100
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Waldemar Rymarkiewicz <waldemar.rymarkiewicz@...to.com>
Cc:	linux-i2c@...r.kernel.org, arnd@...db.de, sameo@...ux.intel.com,
	linux-kernel@...r.kernel.org, hthebaud@...idefr.com,
	matti.j.aaltonen@...ia.com
Subject: Re: [PATCH] NFC: Driver for Inside Secure MicroRead NFC chip

Hi Waldemar,

On Fri, Mar 18, 2011 at 11:40:24AM +0100, Waldemar Rymarkiewicz wrote:
> Add new driver for MicroRead NFC chip connected to i2c bus.
> 
> See Documentation/nfc/nfc-microread.txt.
> 
> Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@...to.com>

Besides the stuff Alan mentioned...

> +struct microread_nfc_platform_data {
> +	unsigned int rst_gpio;
> +	unsigned int irq_gpio;
> +	unsigned int ioh_gpio;

... you should request and setup the GPIOs before using them.


> +free_irq:
> +	free_irq(client->irq, info);
> +free_buf:
> +	kfree(info->buf);
> +free_info:
> +	kfree(info);
> +
> +	dev_info(&client->dev, "Not probed.");
> +	return ret;
> +}

When respinning, you could consider using managed devices (devm_*);
this error path could completely go then.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)