linux-kernel - Re: [PATCH 1/2 v2] watchdog, nmi: Allow hardlockup to panic by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110317185013.7c8be1e0.akpm@linux-foundation.org>
Date:	Thu, 17 Mar 2011 18:50:13 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Don Zickus <dzickus@...hat.com>
Cc:	<x86@...nel.org>, Peter Zijlstra <peterz@...radead.org>,
	jwjstone@...tmail.fm, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2 v2] watchdog, nmi:  Allow hardlockup to panic by
 default

On Mon,  7 Mar 2011 16:37:39 -0500 Don Zickus <dzickus@...hat.com> wrote:

> Add a Kconfig option to allow users to set the hardlockup to panic
> by default.  Also add in a 'nmi_watchdog=nopanic' to override this.
> 

Changelog forgot to tell us "why".

>  			Format: [state][,regs][,debounce][,die]
>  
>  	nmi_watchdog=	[KNL,BUGS=X86] Debugging features for SMP kernels
> -			Format: [panic,][num]
> +			Format: [panic,][nopanic,][num]

It would be better to support panic=[0|1], if that can be simply done
in a back-compatible fashion.

>  static int __init hardlockup_panic_setup(char *str)
>  {
>  	if (!strncmp(str, "panic", 5))
>  		hardlockup_panic = 1;
> +	else if (!strncmp(str, "nopanic", 5))

s/5/7/

> +		hardlockup_panic = 0;
>  	else if (!strncmp(str, "0", 1))
>  		watchdog_enabled = 0;
>  	return 1;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/