linux-kernel - Re: [PATCH v6 0/9] memcg: per cgroup dirty page accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110318142949.GA19859@redhat.com>
Date:	Fri, 18 Mar 2011 10:29:50 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Greg Thelen <gthelen@...gle.com>, Jan Kara <jack@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	containers@...ts.osdl.org, linux-fsdevel@...r.kernel.org,
	Andrea Righi <arighi@...eler.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Minchan Kim <minchan.kim@...il.com>,
	Ciju Rajan K <ciju@...ux.vnet.ibm.com>,
	David Rientjes <rientjes@...gle.com>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Chad Talbott <ctalbott@...gle.com>,
	Justin TerAvest <teravest@...gle.com>,
	Curt Wohlgemuth <curtw@...gle.com>
Subject: Re: [PATCH v6 0/9] memcg: per cgroup dirty page accounting

On Thu, Mar 17, 2011 at 01:43:50PM +0100, Johannes Weiner wrote:

[..]
> So structures roughly like this:
> 
> struct mem_cgroup {
> 	...
> 	/* key is struct backing_dev_info * */
> 	struct rb_root memcg_bdis;
> };
> 
> struct memcg_bdi {
> 	/* key is struct address_space * */
> 	struct rb_root memcg_mappings;
> 	struct rb_node node;
> };
> 
> struct memcg_mapping {
> 	struct address_space *mapping;
> 	struct mem_cgroup *memcg;
> 	struct rb_node node;
> 	atomic_t count;
> };
> 
> struct page_cgroup {
> 	...
> 	struct memcg_mapping *memcg_mapping;
> };

Johannes, didn't you want page->mapping to point to memcg_mapping instead
of increasing the size of page_cgroup?

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/