linux-kernel - Re: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTimg6uc9cq53e54BqLsRzPXH1DNBF9cThHavdJs=@mail.gmail.com>
Date:	Fri, 18 Mar 2011 12:30:55 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Dinh.Nguyen@...escale.com
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux@....linux.org.uk, s.hauer@...gutronix.de,
	u.kleine-koenig@...gutronix.de, arnaud.patard@...-net.org,
	ra5478@...escale.com, xiao-lizhang@...escale.com
Subject: Re: [PATCHv4 2/3] ARM: mx51: Implement code to allow mx51 to enter WFI

Hi Dinh,

On Fri, Mar 18, 2011 at 12:21 PM,  <Dinh.Nguyen@...escale.com> wrote:
...
> +       /* Enable NEON SRPG for all but MX50TO1.0. */
> +       if (cpu_is_mx51() || cpu_is_mx53())
> +               __raw_writel(arm_srpgcr, MXC_SRPG_NEON_SRPGCR);

The comment says that NEON SRPG should not be enabled for MX50 TO1.0,
but your code does not check the MX50 silicon revision.

Regards,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/