lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110318155102.GA22790@angua.secretlab.ca>
Date:	Fri, 18 Mar 2011 09:51:02 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	dbrownell@...rs.sourceforge.net,
	spi-devel-general@...ts.sourceforge.net,
	linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH 1/1] SPI: dw_spi, fix PPC build

On Fri, Mar 18, 2011 at 10:41:17AM +0100, Jiri Slaby wrote:
> Currently, build on PPC dies with:
> In file included from drivers/spi/dw_spi_mmio.c:16:
> include/linux/spi/dw_spi.h:147: error: field ‘tx_sgl’ has incomplete type
> include/linux/spi/dw_spi.h:149: error: field ‘rx_sgl’ has incomplete type
> 
> Add linux/scatterlist.h include to dw_spi.h, because we need to know
> the contents of the structure.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: David Brownell <dbrownell@...rs.sourceforge.net>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mackerras <paulus@...ba.org>

Applied, thanks.

g.

> ---
>  include/linux/spi/dw_spi.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/spi/dw_spi.h b/include/linux/spi/dw_spi.h
> index 6cd10f6..fb0bce5 100644
> --- a/include/linux/spi/dw_spi.h
> +++ b/include/linux/spi/dw_spi.h
> @@ -2,6 +2,7 @@
>  #define DW_SPI_HEADER_H
>  
>  #include <linux/io.h>
> +#include <linux/scatterlist.h>
>  
>  /* Bit fields in CTRLR0 */
>  #define SPI_DFS_OFFSET			0
> -- 
> 1.7.4.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ