linux-kernel - Re: pstore: fix leaking ->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110318185750.GM22723@ZenIV.linux.org.uk>
Date:	Fri, 18 Mar 2011 18:57:50 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	Xiaotian Feng <xtfeng@...il.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: pstore: fix leaking ->i_private

On Fri, Mar 18, 2011 at 11:44:48AM -0700, Luck, Tony wrote:
> From: Tony Luck <tony.luck@...el.com>
> 
> Move kfree() of i_private out of ->unlink() and into ->evict_inode()
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>

Applied (with one trivial change - in your case it doesn't matter, but
people do copy from weird places and conceptually you want to get VFS
end any async activity on inode before starting to tear it apart, so
end_writeback() should normally go first).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/