linux-kernel - Re: [PATCH] block: NULL dereference on error path in __blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=uX1PbKEs1=4mfAXKEpxwy1knWrLZsY9dUNpoh@mail.gmail.com>
Date:	Fri, 18 Mar 2011 15:26:59 -0700
From:	Justin TerAvest <teravest@...gle.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: NULL dereference on error path in __blkdev_get()

On Fri, Mar 18, 2011 at 1:37 AM, Tejun Heo <tj@...nel.org> wrote:
> From: Dan Carpenter <error27@...il.com>
>
> "disk" is always NULL when we goto out.  There was a check for this
> before, but it was removed in 69e02c59a7d9 "block: Don't check events
> while open is in progress".
>
> Signed-off-by: Dan Carpenter <error27@...il.com>
> Acked-by: Tejun Heo <tj@...nel.org>

I was running into this problem too; this patch fixes the problem.

Tested-by: Justin TerAvest <teravest@...gle.com>

>
> diff --git a/fs/block_dev.c b/fs/block_dev.c
> index fbe05cb..7d02afb 100644
> --- a/fs/block_dev.c
> +++ b/fs/block_dev.c
> @@ -1181,9 +1181,9 @@ static int __blkdev_get(struct block_device *bdev, fmode_t mode, int for_part)
>  out_unlock_bdev:
>        mutex_unlock(&bdev->bd_mutex);
>        disk_unblock_events(disk);
> - out:
>        module_put(disk->fops->owner);
>        put_disk(disk);
> + out:
>        bdput(bdev);
>
>        return ret;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/