linux-kernel - Re: 'scheduling while atomic' during ppp connection on 2.6.37.1 and 2.6.38

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110320215826.79cadfe2@lxorguk.ukuu.org.uk>
Date:	Sun, 20 Mar 2011 21:58:26 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jack Stone <jwjstone@...tmail.fm>
Cc:	Mac <kmac@...zta.fm>, linux-kernel@...r.kernel.org,
	linux-ppp@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: 'scheduling while atomic' during ppp connection on 2.6.37.1 and
 2.6.38

> +        spin_lock_irqsave(&dc->spin_mutex, flags);
>           if (port->port.count)
>               room = kfifo_avail(&port->fifo_ul);
> -        mutex_unlock(&port->tty_sem);
> +        spin_unlock_irqrestore(&dc->spin_mutex, flags);

dc->spin_mutex does not protect port->port.count.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/