[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110321110214.5174f1b2@lxorguk.ukuu.org.uk>
Date: Mon, 21 Mar 2011 11:02:14 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Jiri Slaby <jslaby@...e.cz>
Cc: Jack Stone <jwjstone@...tmail.fm>, Mac <kmac@...zta.fm>,
linux-kernel@...r.kernel.org, linux-ppp@...r.kernel.org,
Greg Kroah-Hartman <gregkh@...e.de>,
Jiri Slaby <jirislaby@...il.com>
Subject: Re: 'scheduling while atomic' during ppp connection on 2.6.37.1 and
2.6.38
> Anyway is the test needed at all? I.e. could
> tty->ops->write/chars_in_buffer/ntty_write_room be called with
> port->port.count == 0 at all?
I'm not entirely sure what the Nozomi driver is trying to do. Generally
any case a driver is looking at port->port.count it's a bug and should
not matter with the tty krefs. However the chances are it should be
testing *something* instead in this case.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists