linux-kernel - [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2011 16:37:19 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1


* Takashi Iwai <tiwai@...e.de> wrote:

> Linus,
> 
> please pull sound updates for v2.6.39-rc1 from:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git for-linus

This build failure:

sound/built-in.o: In function `ldo_regulator_remove':
sgtl5000.c:(.text+0x82678): undefined reference to `regulator_unregister'
sound/built-in.o: In function `ldo_regulator_is_enabled':
sgtl5000.c:(.text+0x826c5): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `ldo_regulator_disable':
sgtl5000.c:(.text+0x826ef): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `ldo_regulator_enable':
sgtl5000.c:(.text+0x82756): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `ldo_regulator_get_voltage':
sgtl5000.c:(.text+0x82815): undefined reference to `rdev_get_drvdata'
sound/built-in.o: In function `sgtl5000_probe':

has been pushed upstream - although the build breakage was reported against 
linux-next two weeks ago, with fix provided, in this lkml thread:

  [PATCH -next] soc: sgtl5000 uses regulator interfaces

Please do not push known-broken code upstream.

Randy's fix below resolved the bug for me.

Thanks,

	Ingo

--------------------->
>From 8c7c9a0622d5b1955628961ae193c12d948c1871 Mon Sep 17 00:00:00 2001
From: Randy Dunlap <randy.dunlap@...cle.com>
Date: Fri, 4 Mar 2011 17:33:57 -0800
Subject: [PATCH] soc: Sgtl5000 uses regulator interfaces

sgtl5000 uses regulator interfaces, so make selecting it depend
on REGULATOR.

 sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister'
 sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata'
 sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register'

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
Cc: Liam Girdwood <lrg@...mlogic.co.uk>
Cc: Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc: alsa-devel@...a-project.org
Cc: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Zeng Zhaoming <zhaoming.zeng@...escale.com>
LKML-Reference: <20110304173357.23d36116.randy.dunlap@...cle.com>
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 sound/soc/codecs/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
index d63c175..84818f5 100644
--- a/sound/soc/codecs/Kconfig
+++ b/sound/soc/codecs/Kconfig
@@ -36,7 +36,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_MAX9850 if I2C
 	select SND_SOC_MAX9877 if I2C
 	select SND_SOC_PCM3008
-	select SND_SOC_SGTL5000 if I2C
+	select SND_SOC_SGTL5000 if I2C && REGULATOR
 	select SND_SOC_SN95031 if INTEL_SCU_IPC
 	select SND_SOC_SPDIF
 	select SND_SOC_SSM2602 if I2C
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/