linux-kernel - Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110321161102.GB23614@elte.hu>
Date:	Mon, 21 Mar 2011 17:11:02 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Takashi Iwai <tiwai@...e.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Zeng Zhaoming <b32542@...escale.com>
Subject: Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1


* Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> On Mon, Mar 21, 2011 at 04:37:19PM +0100, Ingo Molnar wrote:
> 
> > has been pushed upstream - although the build breakage was reported against 
> > linux-next two weeks ago, with fix provided, in this lkml thread:
> > 
> >   [PATCH -next] soc: sgtl5000 uses regulator interfaces
> 
> Zheng, you said you'd provide a better patch for this but I've heard
> nothing since?  It's a trivial change you need to make...
> 
> > Please do not push known-broken code upstream.
> 
> That seems like an overreaction, it'll only show up in fairly unrealstic 
> randconfigs [...]

I've seen it trigger with a likelyhood of about 20%, that's not unrealistic.

> [...] and can be trivially avoided by anyone who actually needs the driver - 
> core things like all*config won't be affected, and right now it'll only come 
> up at all if you enable SND_SOC_ALL_CODECS which is purely about build 
> coverage.
> 
> > Randy's fix below resolved the bug for me.
> 
> As indicated that's not a good fix since the affected code is all runtime 
> conditional already. [...]

Well, AFAICS Randy's patch correctly expresses current infrastructure 
dependencies the driver has.

If it's undesirable to disable the driver in the (unlikely but possible) 
SND_SOC_ALL_CODECS=y but !REGULATOR case, i.e. if it's desirable to have the 
driver build more widely, then that can be enhanced further - but first please 
get things to build.

> [...]  It'd be more likely to impede than help the sort of build coverage 
> tests where one would encounter it.

It's an invariant mostly - both Randy's and my testing will find breakages 
regardless of how restrictively enabled this driver is.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/