linux-kernel - Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110321164937.GA6381@elte.hu>
Date:	Mon, 21 Mar 2011 17:49:37 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Takashi Iwai <tiwai@...e.de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jaroslav Kysela <perex@...ex.cz>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Zeng Zhaoming <b32542@...escale.com>
Subject: Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1


* Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:

> On Mon, Mar 21, 2011 at 05:11:02PM +0100, Ingo Molnar wrote:
> > * Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:
> 
> > > As indicated that's not a good fix since the affected code is all runtime 
> > > conditional already. [...]
> 
> > Well, AFAICS Randy's patch correctly expresses current infrastructure 
> > dependencies the driver has.
> 
> That's because the driver code is trivially broken, though - the build
> test has identified a flaw in the driver which we should fix.

Trivially broken how? Your mail in the original thread, if i read it right, 
only claimed that it depends on CONFIG_REGULATOR being present while ideally it 
should be invariant to the value of CONFIG_REGULATOR:

 | Since the regulator on the device is optional this isn't the best fix, the 
 | code should be updated to support building without regulator.

If there is some *other* bug there as well then of course it should be fixed 
instead of worked around.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/