linux-kernel - Re: [PATCH] x86, UV: Fix NMI handler for UV platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110321175304.GM1239@redhat.com>
Date:	Mon, 21 Mar 2011 13:53:04 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Jack Steiner <steiner@....com>,
	tglx@...utronix.de, hpa@...or.com, x86@...nel.org,
	linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] x86, UV: Fix NMI handler for UV platforms

On Mon, Mar 21, 2011 at 07:43:46PM +0300, Cyrill Gorcunov wrote:
> I think Jack might need to setup priority for his notifier, like
> 
> static struct notifier_block uv_dump_stack_nmi_nb = {
> 	.notifier_call	= uv_handle_nmi,
> 	.priority	= NMI_LOCAL_HIGH_PRIOR+1,
> };
> 
> so it would be called before perf nmi. Don, am I right?

Unless they added register to detect the external nmi button has been
pressed this shouldn't work and in fact if you run 'perf' you will
probably trigger stack traces for all the cpus on your first NMI.  That is
what has been explained to me privately.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/