linux-kernel - [PATCH][resend] Remove pointless memset in nfsacl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 21 Mar 2011 20:35:49 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	linux-nfs@...r.kernel.org
cc:	Trond Myklebust <Trond.Myklebust@...app.com>,
	Milton Miller <miltonm@....com>,
	Chuck Lever <chuck.lever@...cle.com>,
	linux-kernel@...r.kernel.org, Neil Brown <neilb@...e.de>,
	bfields@...ldses.org
Subject: [PATCH][resend] Remove pointless memset in nfsacl_encode()

Remove pointless memset() in nfsacl_encode().

Thanks to Trond Myklebust <Trond.Myklebust@...app.com> for pointing out 
that it is not needed since posix_acl_init() will set everything 
regardless..

Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
 nfsacl.c |    1 -
 1 file changed, 1 deletion(-)

 Patch against up-to-date Linus' tree.

diff --git a/fs/nfs_common/nfsacl.c b/fs/nfs_common/nfsacl.c
index 84c27d6..ec0f277 100644
--- a/fs/nfs_common/nfsacl.c
+++ b/fs/nfs_common/nfsacl.c
@@ -117,7 +117,6 @@ int nfsacl_encode(struct xdr_buf *buf, unsigned int base, struct inode *inode,
 		 * invoked in contexts where a memory allocation failure is
 		 * fatal.  Fortunately this fake ACL is small enough to
 		 * construct on the stack. */
-		memset(acl2, 0, sizeof(acl2));
 		posix_acl_init(acl2, 4);
 
 		/* Insert entries in canonical order: other orders seem



-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/