linux-kernel - Re: [PATCH] mm: optimize replace_page_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110321150622.4b5b088e.akpm@linux-foundation.org>
Date:	Mon, 21 Mar 2011 15:06:22 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Miklos Szeredi <mszeredi@...e.cz>
Cc:	Minchan Kim <minchan.kim@...il.com>, linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Rik van Riel <riel@...hat.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Mel Gorman <mel@....ul.ie>
Subject: Re: [PATCH] mm: optimize replace_page_cache_page

On Thu, 24 Feb 2011 11:56:55 +0100
Miklos Szeredi <mszeredi@...e.cz> wrote:

> On Thu, 2011-02-24 at 08:37 +0900, Minchan Kim wrote:
> > On Thu, Feb 24, 2011 at 7:44 AM, Andrew Morton
> > <akpm@...ux-foundation.org> wrote:
> > > On Sun, 20 Feb 2011 08:41:21 +0900
> > > Minchan Kim <minchan.kim@...il.com> wrote:
> > >
> > >> Resend.
> > >
> > > Reignore.
> > >
> > >> he patch is based on mmotm-2011-02-04 +
> > >> mm-add-replace_page_cache_page-function-add-freepage-hook.patch.
> > >>
> > >> On Fri, Feb 11, 2011 at 01:33:46AM +0900, Minchan Kim wrote:
> > >> > This patch optmizes replace_page_cache_page.
> > >> >
> > >> > 1) remove radix_tree_preload
> > >> > 2) single radix_tree_lookup_slot and replace radix tree slot
> > >> > 3) page accounting optimization if both pages are in same zone.
> > >> >
> > >> > Cc: Miklos Szeredi <mszeredi@...e.cz>
> > >> > Cc: Rik van Riel <riel@...hat.com>
> > >> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> > >> > Cc: Mel Gorman <mel@....ul.ie>
> > >> > Signed-off-by: Minchan Kim <minchan.kim@...il.com>
> > >> > ---
> > >> >  mm/filemap.c |   61 ++++++++++++++++++++++++++++++++++++++++++++++++---------
> > >> >  1 files changed, 51 insertions(+), 10 deletions(-)
> > >> >
> > >> > Hi Miklos,
> > >> > This patch is totally not tested.
> > >> > Could you test this patch?
> > >
> > > ^^^ Because of this.
> > >
> > > Is it tested yet?
> > >
> > 
> > Miklos. Could you test this?
> > If you are busy, let me know how to test it. I will.
> > Thanks.
> 
> Grab git version of libfuse and do something like this:
> 
>  fuse/example/fusexmp_fh -obig_writes /mnt/fuse/
>  dd if=/tmp/random0 of=/mnt/fuse/tmp/random1 bs=1M
>  md5sum /tmp/radom0 /tmp/random1
> 
> This should exercise the page moving.
> 
> I'll review and test the patch when I have some time.
> 

Too late.  It took months to half-finish Miklos's patch and now I'm
sitting on other patches which depend on it, so it's going in.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/