linux-kernel - Re: TTY loosing data with u

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110322085344.GN1837@legolas.emea.dhcp.ti.com>
Date:	Tue, 22 Mar 2011 10:53:47 +0200
From:	Felipe Balbi <balbi@...com>
To:	Felipe Balbi <balbi@...com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Stefan Bigler <stefan.bigler@...mile.com>,
	Greg KH <greg@...ah.com>, linux-kernel@...r.kernel.org,
	linux-usb@...r.kernel.org
Subject: Re: TTY loosing data with u_serial gadget

On Mon, Mar 21, 2011 at 11:32:57AM +0200, Felipe Balbi wrote:
> On Fri, Mar 18, 2011 at 06:06:57PM +0000, Alan Cox wrote:
> > > I had the same problem while I was working at Nokia developing the N900.
> > > I even sent a patch (twice) with Alan Cox on the loop but nothing has
> > > happened.
> > 
> > http://lkml.indiana.edu/hypermail/linux/kernel/0910.0/02347.html
> > 
> > is I assume the thread you are talking about - which ground to a halt
> > without actually figuring out what you were seeing and what was really
> > going on.
> > 
> > http://permalink.gmane.org/gmane.linux.usb.general/28976
> > 
> > would be the second generation one which was somewhat longer after I
> > ceased to be tty maintainer so I can't really say it never got upstream.
> > 
> > I still think its the right thing to do, so perhaps it's worth reposting
> > it, especially if it fixes this case too.
> 
> Ok, I'll update that patch and re-send. I'll compile test on x86 and
> boot test on an ARM box, so it would be cool to have Acks from several
> people before applying, just in case.

Patch attached, please give it a good round of test as I don't have how
to exercise all line disciplines. I ran 100 randconfigs over night and
no warnings or erros on that area, at least not that I could see (so
many warning while compiling the kernel :-( )

-- 
balbi

View attachment "0001-ty-make-receive_buf-return-the-amout-of-bytes-receive.diff" of type "text/x-diff" (25088 bytes)