linux-kernel - Re: [PATCH v7] MAX8997/8966 MFD: Add IRQ control feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110322115134.GF2351@sortiz-mobl>
Date:	Tue, 22 Mar 2011 12:51:35 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	MyungJoo Ham <myungjoo.ham@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	myungjoo.ham@...il.com
Subject: Re: [PATCH v7] MAX8997/8966 MFD: Add IRQ control feature

Hi MyungJoo,

On Mon, Mar 21, 2011 at 05:08:24PM +0900, MyungJoo Ham wrote:
> +static struct irq_chip max8997_irq_chip = {
> +	.name			= "max8997",
> +#ifdef CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED
> +	.irq_bus_lock		= max8997_irq_lock,
> +	.irq_bus_sync_unlock	= max8997_irq_sync_unlock,
> +	.irq_mask		= max8997_irq_mask,
> +	.irq_unmask		= max8997_irq_unmask,
> +#else /* CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED */
> +	.bus_lock		= max8997_irq_lock,
> +	.bus_sync_unlock	= max8997_irq_sync_unlock,
> +	.mask			= max8997_irq_mask,
> +	.unmask			= max8997_irq_unmask,
> +#endif /* CONFIG_GENERIC_HARDIRQS_NO_DEPRECATED */
> +};
You actually don't need to define both pointer sets. Setting the irq_* ones
should be enough for both configs.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/