lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Mar 2011 08:32:15 +0800 From: Shaohua Li <shaohua.li@...el.com> To: Jens Axboe <jaxboe@...ionio.com> Cc: Vivek Goyal <vgoyal@...hat.com>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "hch@...radead.org" <hch@...radead.org>, "jmoyer@...hat.com" <jmoyer@...hat.com> Subject: Re: [PATCH 04/10] block: initial patch for on-stack per-task plugging On Mon, 2011-03-21 at 17:20 +0800, Jens Axboe wrote: > On 2011-03-21 07:52, Shaohua Li wrote: > >> Gave it a quick test spin, as suspected it had a few issues. This one > >> seems to work. Can you toss it through that workload and see if it fares > >> better? > > yes, this fully restores the regression I saw. But I have accounting > > issue: > > Great! > > > 1. The merged request is already accounted when it's added into plug > > list > > Good catch. I've updated the patch and merged it now, integrating this > accounting fix. > > > 2. drive_stat_acct() is called without any protection in > > __make_request(). So there is race for in_flight accounting. The race > > exists after stack plug is added, so not because of this issue. > > Below is the extra patch I need to do the test. > > Looks fine. Can I add your signed-off-by to this patch? I'll merge it as > a separate fix. Sure. Signed-off-by: Shaohua Li<shaohua.li@...el.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists