linux-kernel - Re: [PATCH 6/7] char/mei: Header file contain the Userland API, (IOCTL and its struct)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110322162603.GB14737@suse.de>
Date:	Tue, 22 Mar 2011 09:26:03 -0700
From:	Greg KH <gregkh@...e.de>
To:	Oren Weil <oren.jer.weil@...el.com>
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	david@...dhou.se
Subject: Re: [PATCH 6/7] char/mei: Header file contain the Userland API,
 (IOCTL and its struct)

On Tue, Mar 22, 2011 at 12:51:31PM +0200, Oren Weil wrote:
> +/*
> + * Intel MEI client information struct
> + */
> +struct mei_client {
> +	u32 max_msg_length;
> +	u8 protocol_version;
> +	u8 reserved[3];
> +} __packed;

As this is passing the kernel/user boundry, you need to use the proper
data types for it.

So use __u32 and __u8 here please.

> +/*
> + * IOCTL Connect Client Data structure
> + */
> +struct mei_connect_client_data {
> +	union {
> +		uuid_le in_client_uuid;
> +		struct mei_client out_client_propeties;
> +	} d;

Why not an anonymous union?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/